Skip to content

Conversation

@jamesobutler
Copy link
Contributor

This updates ITK to use in Plus build CI jobs.

This corresponds to the change in PlusToolkit/PlusBuild#96. @Sunderlandkyl Should these 2 places (Pluslib CI and the PlusBuild) be kept in sync?

@jamesobutler
Copy link
Contributor Author

Looks like PRs triggered by a ThirdParty that does not have access to https://github.com/PerkLab/PLTools will have the CI jobs fail trying to build Plus as seen in https://github.com/PlusToolkit/PlusLib/actions/runs/16105620098/job/45441082910?pr=1241.

@Sunderlandkyl Should the build test be based on devices that aren't part of PLTools so PRs from anyone can pass the results?Maybe tests associated with PLTools should be run on a cron schedule outside of each PR? Or do we actually desire to check PLTools compatibility for each PR?

@Sunderlandkyl
Copy link
Contributor

Looks like PRs triggered by a ThirdParty that does not have access to https://github.com/PerkLab/PLTools will have the CI jobs fail trying to build Plus as seen in https://github.com/PlusToolkit/PlusLib/actions/runs/16105620098/job/45441082910?pr=1241.

Yeah, in retrospect, that makes sense. Since we build all of the nightly packages including PLTools devices in the nighly task, we can skip the other ones for the ci. I'll update the action to remove PLTools devices.

@Sunderlandkyl Sunderlandkyl merged commit cc78695 into PlusToolkit:master Jul 8, 2025
9 checks passed
@jamesobutler jamesobutler deleted the itk-5.4.4 branch July 8, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants