Open
Conversation
diivm
force-pushed
the
devel/docker
branch
2 times, most recently
from
384b6fc to
7fe0981
Compare
kunaltyagi
reviewed
Aug 22, 2021
Dockerfile
Outdated
| # Install libclang via development branch on https://apt.llvm.org/ | ||
| RUN wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add - | ||
| RUN echo 'deb http://apt.llvm.org/focal/ llvm-toolchain-focal-12 main' | tee -a /etc/apt/sources.list | ||
| RUN echo 'deb-src http://apt.llvm.org/focal/ llvm-toolchain-focal-12 main' | tee -a /etc/apt/sources.list |
Member
There was a problem hiding this comment.
Why are the sourced needed? To install libclang-12-dev?
Collaborator
Author
There was a problem hiding this comment.
To install a development branch basically.
v12 is stable now, but we'll need this when we want to bump to v14 (currently developmental).
Member
There was a problem hiding this comment.
Also, don't use sources.list, instead create a new file in sources.list.d
Collaborator
Author
There was a problem hiding this comment.
My bad, this method was to install stable branches that were not directly accessible via apt-get install, not for developmental branches. Hence, I've removed this block.
kunaltyagi
reviewed
Aug 31, 2021
Comment on lines
+6
to
+8
| RUN apt-get update -y && apt-get install -y python3-pip libclang-12-dev python3-clang-12 | ||
|
|
||
| RUN pip install -r requirements.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerfilepytest.ymlblack.yml: only needs the formatter, is faster to just keep as is.