fix: set character limit in schemas as DB limit (25 instead of 20)#23
fix: set character limit in schemas as DB limit (25 instead of 20)#23
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated pnpm in package.json and refactored URL validation: increased short code max length from 20 to 25; made editUrlSchema the base and derive createUrlSchema from it; removed the CreateUrlInput export. Changes
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/lib/validations.ts`:
- Line 7: The validation call currently uses .min(2, "Short code must be at
least 3 characters") which mismatches the error text; update the validator by
changing the .min call to .min(3, "Short code must be at least 3 characters") so
the constraint matches the message (locate the .min(2, ...) invocation in the
validation schema and adjust to .min(3, ...)); if instead you prefer a
2-character minimum, change the error string to "Short code must be at least 2
characters" in the same place.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4996b46e-72c8-4660-b746-e6413bb9e655
📒 Files selected for processing (3)
package.jsonsrc/lib/schemas.tssrc/lib/validations.ts
No description provided.