Fix V6 parameter editor date, scroll, and chart issues#839
Merged
Conversation
- Use toLocalDateString/fromLocalDateString in YearlyValueSelectorV6 and DefaultValueSelectorV6 to prevent off-by-one-day timezone errors - Replace Radix ScrollArea with native overflow-y scroll in PolicyParameterTree and ParameterSidebar to fix menu scrollability - Fix getNiceTicks to ensure last tick covers dMax, preserving y-axis headroom when 10% padding is applied - Add 10% y-axis headroom above max data point in HistoricalValues chart - Remove duplicate "Historical values" heading and excessive top margin - Reduce chart left margin and card padding for tighter layout - Add tests for local date string round-trips and getNiceTicks headroom Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Port the unnamed policy warning from PolicyCreationModal to PolicyBrowseModal so users can create policies without a name via the report builder browse flow. Shows a confirmation dialog instead of silently blocking or disabling the button. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix DialogContent default max-width: use explicit 32rem instead of tw:sm:max-w-lg which resolves to 16px due to spacing token override - Use outline variant for Cancel buttons in warning dialogs - Disable create/save buttons when no parameters are modified - Apply same fixes to both PolicyBrowseModal and PolicyCreationModal Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #838
Summary
toLocalDateString/fromLocalDateStringinYearlyValueSelectorV6andDefaultValueSelectorV6to prevent off-by-one-day errors in behind-UTC timezonesScrollAreawith nativeoverflow-y: scrollinPolicyParameterTreeandParameterSidebarso the parameter menu scrolls properly in flex layoutsgetNiceTicksto guarantee the last tick coversdMax, and add 10% padding above the max data point in the historical values chartTest plan
npm test— 52 passing tests including new date round-trip and getNiceTicks headroom tests🤖 Generated with Claude Code