Add data validation improvements to country-models agents#125
Merged
Conversation
Based on real errors found in policyengine-us#7726 (SNAP utility allowances): - rules-engineer: Add YAML structural integrity checks (no orphaned values after metadata block), breakdown metadata correctness validation, and multi-source cross-referencing requirements for parameter values - implementation-validator: Add Phase 0 (YAML structural integrity) before semantic checks, covering orphaned metadata values, breakdown mismatches, duplicate keys, and non-standard effective dates - test-creator: Require sub-region/breakdown coverage in tests (one test per region plus default/fallback case) These address: WY value orphaned after metadata, wrong breakdown variable (state_code vs snap_utility_region), incorrect IN effective dates, and missing AK/NY sub-region tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on real errors found in policyengine-us#7726 (SNAP utility allowances), adds validation improvements to three agents:
Errors these prevent
metadata:blockbreakdown: [state_code]when keys areAK_C,NY_NYCTest plan
claude --plugin-dir🤖 Generated with Claude Code