Open
Conversation
|
Interesting that you chose to separate the camera and the player to accomplish this. On my fork, as far as I remember, I simply made the player stop if they hit a certain point so basically you hit the ground and just lay there lol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since you'd just infinetely fall on death, I figured it would be better to stop the camera on death.
I've seperated the camera and player calculations (and improved some formatting) so when you die, the camera stops and you just drop below the screen, but the background stays there.
Note that afaik the player's still being rendered so ig this might be a slight nuance but whatever
Also added some standard fixes of the imports and a gitignore