Feat/online cache playback#1719
Open
0Chencc wants to merge 3 commits intoPredidit:mainfrom
Open
Conversation
在 changeEpisode() 中添加缓存检查，已下载的集数跳过 WebView 解析直接播放本地文件，弹幕仍从网络获取。
Request.get/post 默认捕获 DioException 并返回伪造的 200 Response， 导致下游 JSON 解析产生类型错误。为 bangumi/plugin/damaku 的所有 请求调用添加 shouldRethrow: true，让异常正确传播到已有的 catch 块。
Owner
|
老实说，我对这个功能有些忌惮，担心它会导致一些缓存和剧集错位的问题 我会仔细检查这个PR并把它放到 2.0.2 2.0.1 已经累积太多更改 |
Contributor
Author
|
我们要来引入这个改动了吗 |
Owner
|
抱歉，我在发布 2.0.2 时忘记了这个改动 我稍后查看这个PR |
Contributor
Author
|
好嘞 |
Contributor
Author
|
对于此处的缓存复用我们还要继续考虑合并吗？如果考虑合并我会更新代码 |
Owner
|
稍等，我还没有给出修改，我先进行一些测试 |
Owner
|
还是觉得这是个超危险的功能，bug 数量会超出想象 你觉得在番剧详情页面提供从缓存播放的按钮，或者在开始观看按钮按下后提供从缓存播放和从视频规则播放的选项怎么样 使用这种显式的选择，而不是把相关逻辑藏起来 |
Contributor
Author
XD，如果仅仅只是实现一个从缓存播放的按钮，似乎也没有必要，我们的下载已经支持按集分配了。 我想想看，确实这个功能如果实现的话会连带着产生许多bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个分支实现了对缓存的复用，同时我设置了回退机制，当遇到错误时可以退回到在线播放。