fix: use safe tar extraction in env pull to prevent path traversal#505
Open
JannikSt wants to merge 1 commit into
Open
fix: use safe tar extraction in env pull to prevent path traversal#505JannikSt wants to merge 1 commit into
JannikSt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace unsafe
tar.extractall()in env pull with the existing_safe_tar_extracthelper that validates archive members against path traversal, symlink, and absolute path attacks._safe_tar_extractinstead of rawextractallin the pull commandValueErrorfrom validation alongsideTarErrorNote
Medium Risk
Touches archive extraction in the CLI download path, which is security-sensitive; behavior changes are small but could cause pulls to fail if archives contain previously-accepted unsafe entries.
Overview
Security hardening for
prime env pull. Replaces directtar.extractall()with_safe_tar_extract()so pulled environment archives are validated against path traversal, absolute paths, and link entries before extraction.Extraction now also treats validation failures (
ValueError) as user-facing extraction errors alongsidetarfile.TarError.Reviewed by Cursor Bugbot for commit 86a6c28. Bugbot is set up for automated code reviews on this repo. Configure here.