tunnel labels#586
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aaf8ad842d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38a43935df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee9d151543
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 85db6df. Configure here.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87111ffeb0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Note
Medium Risk
Expands tunnel API/CLI request shapes (labels, pagination/sorting, bulk-delete scoping) which could break compatibility with the backend or existing scripts if contracts differ. Bulk deletion behavior is broadened and now supports label/team/user scoping, increasing the impact of parameter mistakes.
Overview
Adds label support and richer metadata across tunnel creation and reporting:
TunnelInfonow includesname,local_port,labels,team_id, and lifecycle timestamps, andTunnel/TunnelClient.create_tunnelcan sendlabelsduring registration.Extends
TunnelClient.list_tunnelsto support label/status filters plus pagination and sorting params, and updatesget_tunnel/list_tunnelsto populate the new fields.bulk_delete_tunnelsis generalized to delete by IDs or bylabelswith optionalteamId/userIdscoping and anall_usersflag (with validation that team scope is required).Updates the
prime tunnelCLI:startaccepts--label,listadds filtering/sorting/pagination plus optional--output json, andstopnow supports--labeldeletes and tighter mutual-exclusion/confirmation logic;--allcurrently pre-lists/paginates IDs as a migration fallback before bulk delete. Adds targeted unit/CLI tests for these behaviors.Reviewed by Cursor Bugbot for commit 87111ff. Bugbot is set up for automated code reviews on this repo. Configure here.