Warn on SDK config load failures#617
Open
d42me wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds warning logs when SDK config files cannot be parsed/read across MCP, evals, sandboxes, and tunnel packages, with a caplog regression test.
Note
Low Risk
Low risk: only adds warning logs and slightly broadens exception handling when reading local config files; no behavior change beyond improved visibility and consistent fallback.
Overview
Adds warning logs across the various SDK
Configloaders (evals, MCP server, sandboxes, tunnel) when~/.prime/config.jsoncannot be read or parsed, and standardizes the failure path to fall back to an empty config (catchingOSErrorinstead ofIOError).Introduces a regression test (
test_sdk_config_load_warnings.py) that parametrically verifies each package emits the warning and returns{}when the config file contains invalid JSON.Reviewed by Cursor Bugbot for commit de7a284. Bugbot is set up for automated code reviews on this repo. Configure here.