Use tracked environment package URLs#630
Open
d42me wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9466c3ac37
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9466c3a to
ad31083
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f7dbb09. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Switch environment package downloads to prefer tracked_package_url while falling back to package_url for compatibility, and follow redirects when streaming package archives.
Note
Medium Risk
Changes environment archive download behavior in both the CLI and Lab cache by switching URL selection and enabling redirects, which could affect how/where packages are fetched. Scope is limited to download paths and covered by updated tests.
Overview
Environment downloads now prefer tracked URLs. Archive fetches for
prime env pull, private env build/pull, and Lab’s source cache use a shared_environment_package_download_url()helper that selectstracked_package_urlfirst and falls back topackage_urlfor compatibility.HTTP streaming follows redirects. All
httpx.streamcalls that download environment tarballs now setfollow_redirects=True, with tests updated/added to assert tracked-URL preference and redirect-following behavior.Reviewed by Cursor Bugbot for commit a422cac. Bugbot is set up for automated code reviews on this repo. Configure here.