Added untyped Hydrator so type can be passed at runtime#8
Open
cjbush wants to merge 1 commit intoPrintsCharming:masterfrom
Open
Added untyped Hydrator so type can be passed at runtime#8cjbush wants to merge 1 commit intoPrintsCharming:masterfrom
cjbush wants to merge 1 commit intoPrintsCharming:masterfrom
Conversation
Owner
|
This is fantastic. Thank you! It's a pretty big change so I'll rev it up appropriately. This is a really great addition. |
Author
|
Thanks. The limitation is obviously that you can't really pass in LINQ expressions for data constraints. I was thinking about potentially adding the ability to specify properties by name or by type, so say something like "for all properties that are ints, give it a range of 1-10" or something like that. I didn't want to go that far without getting your thoughts, though. |
Owner
|
This is true. Which is why there's a failing test on Generic_CanGetSingleRestrictedDescriptionCustomer I suppose that test doesn't really need to exist if we hold that in that usage you cannot add data constraints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.