FOUR-29068 Add NAYRA_REST_API_HOST support to ScriptDockerNayraTrait #8713
+200
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When NAYRA_REST_API_HOST is set in .env, the trait uses that URL
directly instead of Docker discovery, enabling Nayra script execution
where automatic discovery fails (macOS/Docker Desktop, port conflicts,
external Nayra services).
Problem (without this change):
- ScriptDockerNayraTrait uses Docker discovery (docker inspect,
hostname -i) to build http://{ip}:{port}/run_script
- On macOS/Docker Desktop: IPv6 from hostname -i produces invalid URLs;
container IP may be unreachable from host
- Port 8080 conflict: nginx or other service responds instead of Nayra
- External Nayra: no way to configure a fixed URL
Solution:
- Add getNayraBaseUrl(): returns NAYRA_REST_API_HOST if set, else
getNayraInstanceUrl()
- Update handleNayraDocker() to use getNayraBaseUrl()
- Update ensureNayraServerIsRunning(): when NAYRA_REST_API_HOST is set
and connection fails, throw ScriptException instead of bringUpNayra()
Configuration (.env):
NAYRA_REST_API_HOST=http://localhost:8081
Backward compatible: if not set, original Docker discovery flow is used.
Affected file: ProcessMaker/Models/ScriptDockerNayraTrait.php
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NAYRA_REST_API_HOST is set in .env, the trait uses that URL directly instead of Docker discovery, enabling Nayra script execution where automatic discovery fails (macOS/Docker Desktop, port conflicts, external Nayra services).
Problem (without this change):
Solution:
Configuration (.env):
NAYRA_REST_API_HOST=http://localhost:8081
Backward compatible: if not set, original Docker discovery flow is used.
Affected file: ProcessMaker/Models/ScriptDockerNayraTrait.php
Related tickets:
https://processmaker.atlassian.net/browse/FOUR-29068
ci:deploy