bugfix/FOUR-30846: Completed tasks can be reassigned.#8798
bugfix/FOUR-30846: Completed tasks can be reassigned.#8798CarliPinell wants to merge 1 commit intodevelopfrom
Conversation
|
eiresendez
left a comment
There was a problem hiding this comment.
👍 👍 approved with just minor comments!
| return false; | ||
| } | ||
| if (typeof status === "string") { | ||
| if (status === "CLOSED" || status === "Completed") { |
There was a problem hiding this comment.
🟠 Improvements
resources/js/tasks/components/TasksPreview.vue:292
isTaskCompleted() mixes canonical API/DB state with UI display values: CLOSED, Completed, and rendered badge HTML/CSS classes.
Reasoning: CLOSED is the real task status. Completed is a UI label/alias and can be translated or absent depending on where the task object comes from. Parsing badge classes is also fragile.
Suggestion: if the frontend needs a visual disabled state, use a canonical field only, such as task.status === "CLOSED" or task.advanceStatus === "completed". Do not rely on translated labels or rendered HTML.





Solution
How to Test
Related Tickets & Packages
https://processmaker.atlassian.net/browse/FOUR-30846
Code Review Checklist