FOUR-28073 Canceled case still progresses to Completed#8801
Open
FOUR-28073 Canceled case still progresses to Completed#8801
Conversation
Description: Race: cancel closed only in-memory tokens while parallel gateways could create new ACTIVE tokens afterward; completing them overwrote CANCELED with COMPLETED. Bulk-close stray tokens on cancel, block task completion and new activations when status is CANCELED, skip COMPLETED persistence if already canceled, guard script completion, and rethrow HttpResponseException from BPMN actions so 422 responses are not swallowed as request errors. Related tickets: https://processmaker.atlassian.net/browse/FOUR-28073
|
Contributor
|
QA server K8S was successfully deployed https://ci-778d7fdf17.engk8s.processmaker.net |
caleeli
reviewed
May 5, 2026
| if ($this->processId !== 'non_persistent_process') { | ||
| HandleRedirectListener::sendRedirectToEvent(); | ||
| } | ||
| } catch (HttpResponseException $exception) { |
caleeli
reviewed
May 5, 2026
|
|
||
| $response = $script->runScript($data, $configuration, $token->getId(), $errorHandling->timeout()); | ||
|
|
||
| if (ProcessRequest::query()->whereKey($instance->getKey())->value('status') === 'CANCELED') { |
Contributor
There was a problem hiding this comment.
@gproly Not sure if this is needed, because completeTask verifies that the token is ACTIVE. Could you try to remove this code?
caleeli
reviewed
May 5, 2026
| WorkflowManager::completeTask($processModel, $instance, $token, $response['output']); | ||
| } catch (ConfigurationException $exception) { | ||
| $output = $exception->getMessageForData($token); | ||
| if (ProcessRequest::query()->whereKey($instance->getKey())->value('status') === 'CANCELED') { |
Contributor
There was a problem hiding this comment.
@gproly Not sure if this is needed, because completeTask verifies that the token is ACTIVE. Could you try to remove this code?
caleeli
reviewed
May 5, 2026
| //Validate data | ||
| $element = $token->getDefinition(true); | ||
| $this->validateData($data, $definitions, $element); | ||
| if ($instance instanceof ProcessRequest) { |
Contributor
There was a problem hiding this comment.
@gproly Not sure if this is needed, because CompleteActivity should verify that the token is ACTIVE. Could you check if this verification could go to the Job?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Race: cancel closed only in-memory tokens while parallel gateways could
create new ACTIVE tokens afterward; completing them overwrote CANCELED
with COMPLETED. Bulk-close stray tokens on cancel, block task completion
and new activations when status is CANCELED, skip COMPLETED persistence
if already canceled, guard script completion, and rethrow HttpResponseException
from BPMN actions so 422 responses are not swallowed as request errors.
Related tickets:
https://processmaker.atlassian.net/browse/FOUR-28073
ci:deploy