Skip to content

Make use of a Session() object for connection pooling #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tarnfeld wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make use of a Session() object for connection pooling #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75b4cd2
Added helper methods for requests that use a share session
tarnfeld Oct 1, 2014
36b1f6c
Switch all API calls to be made through the shared session
tarnfeld Oct 1, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions pywebhdfs/webhdfs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def __init__(self, host='localhost', port='50070', user_name=None):
self.host = host
self.port = port
self.user_name = user_name
self.session = requests.Session()

# create base uri to be used in request operations
self.base_uri = 'http://{host}:{port}/webhdfs/v1/'.format(
Expand Down Expand Up @@ -78,7 +79,7 @@ def create_file(self, path, file_data, **kwargs):
# make the initial CREATE call to the HDFS namenode
optional_args = kwargs
uri = self._create_uri(path, operations.CREATE, **optional_args)
init_response = requests.put(uri, allow_redirects=False)
init_response = self._put(uri, allow_redirects=False)

if not init_response.status_code == httplib.TEMPORARY_REDIRECT:
_raise_pywebhdfs_exception(
Expand All @@ -88,7 +89,7 @@ def create_file(self, path, file_data, **kwargs):
# initial response from the namenode and make the CREATE request
# to the datanode
uri = init_response.headers['location']
response = requests.put(
response = self._put(
uri, data=file_data,
headers={'content-type': 'application/octet-stream'})

Expand Down Expand Up @@ -133,7 +134,7 @@ def append_file(self, path, file_data, **kwargs):
# make the initial APPEND call to the HDFS namenode
optional_args = kwargs
uri = self._create_uri(path, operations.APPEND, **optional_args)
init_response = requests.post(uri, allow_redirects=False)
init_response = self._post(uri, allow_redirects=False)

if not init_response.status_code == httplib.TEMPORARY_REDIRECT:
_raise_pywebhdfs_exception(
Expand All @@ -143,7 +144,7 @@ def append_file(self, path, file_data, **kwargs):
# initial response from the namenode and make the APPEND request
# to the datanode
uri = init_response.headers['location']
response = requests.post(
response = self._post(
uri, data=file_data,
headers={'content-type': 'application/octet-stream'})

Expand Down Expand Up @@ -180,7 +181,7 @@ def read_file(self, path, **kwargs):
optional_args = kwargs
uri = self._create_uri(path, operations.OPEN, **optional_args)

response = requests.get(uri, allow_redirects=True)
response = self._get(uri, allow_redirects=True)

if not response.status_code == httplib.OK:
_raise_pywebhdfs_exception(response.status_code, response.content)
Expand Down Expand Up @@ -213,7 +214,7 @@ def make_dir(self, path, **kwargs):
optional_args = kwargs
uri = self._create_uri(path, operations.MKDIRS, **optional_args)

response = requests.put(uri, allow_redirects=True)
response = self._put(uri, allow_redirects=True)

if not response.status_code == httplib.OK:
_raise_pywebhdfs_exception(response.status_code, response.content)
Expand Down Expand Up @@ -243,7 +244,7 @@ def rename_file_dir(self, path, destination_path):
uri = self._create_uri(path, operations.RENAME,
destination=destination_path)

response = requests.put(uri, allow_redirects=True)
response = self._put(uri, allow_redirects=True)

if not response.status_code == httplib.OK:
_raise_pywebhdfs_exception(response.status_code, response.content)
Expand Down Expand Up @@ -274,7 +275,7 @@ def delete_file_dir(self, path, recursive=False):
"""

uri = self._create_uri(path, operations.DELETE, recursive=recursive)
response = requests.delete(uri, allow_redirects=True)
response = self._delete(uri, allow_redirects=True)

if not response.status_code == httplib.OK:
_raise_pywebhdfs_exception(response.status_code, response.content)
Expand Down Expand Up @@ -332,7 +333,7 @@ def get_file_dir_status(self, path):
"""

uri = self._create_uri(path, operations.GETFILESTATUS)
response = requests.get(uri, allow_redirects=True)
response = self._get(uri, allow_redirects=True)

if not response.status_code == httplib.OK:
_raise_pywebhdfs_exception(response.status_code, response.content)
Expand Down Expand Up @@ -388,7 +389,7 @@ def list_dir(self, path):
"""

uri = self._create_uri(path, operations.LISTSTATUS)
response = requests.get(uri, allow_redirects=True)
response = self._get(uri, allow_redirects=True)

if not response.status_code == httplib.OK:
_raise_pywebhdfs_exception(response.status_code, response.content)
Expand Down Expand Up @@ -430,6 +431,18 @@ def _create_uri(self, path, operation, **kwargs):

return uri

def _put(self, *args, **kwargs):
return self.session.put(*args, **kwargs)

def _post(self, *args, **kwargs):
return self.session.post(*args, **kwargs)

def _get(self, *args, **kwargs):
return self.session.get(*args, **kwargs)

def _delete(self, *args, **kwargs):
return self.session.delete(*args, **kwargs)


def _raise_pywebhdfs_exception(resp_code, message=None):

Expand Down