feat: add distiller algorithm#479
Merged
minettekaum merged 4 commits intomainfrom Feb 5, 2026
Merged
Conversation
| # Default values are chosen based on Table 1 of the FORA paper | ||
| return [ | ||
| Boolean( | ||
| "agressive", |
There was a problem hiding this comment.
Bug: Hyperparameter name "agressive" is misspelled
The hyperparameter agressive is misspelled (missing a 'g' - should be aggressive). This is a user-facing configuration parameter that users will need to specify via smash_config["agressive"]. Using a misspelled parameter name in the public API will cause confusion and forces users to use the incorrect spelling. The typo is used consistently throughout the file (lines 132, 137, 143, 148, 154, 158, 164, 168), so it won't cause runtime errors, but it's a poor API design.
b54def4 to
b29872d
Compare
|
This PR has been inactive for 10 days and is now marked as stale. |
|
This PR has been inactive for 10 days and is now marked as stale. |
Contributor
Author
|
not stale |
b29872d to
69e10db
Compare
Co-authored-by: John Rachwan <johnrachwan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The distiller algorithm
hyperadded to Pruna.hyperalgorithm is in filesrc/pruna/algorithms/hyper.pytests/algorithms/testers/hyper.pydistiller,enhancerandrecamplertags added tosrc/pruna/algorithms/base/tags.pyPEFTadded topyproject.tomlType of Change
How Has This Been Tested?
By the tests in
tests/algorithms/testers/hyper.pyChecklist