Feat/fetch GitHub repo#217
Open
InbarDanieli wants to merge 16 commits intoPull-Request-Community:masterfrom
Open
Feat/fetch GitHub repo#217InbarDanieli wants to merge 16 commits intoPull-Request-Community:masterfrom
InbarDanieli wants to merge 16 commits intoPull-Request-Community:masterfrom
Conversation
…-community into feat/fetch-github-repo
…-community into feat/fetch-github-repo
✅ Deploy Preview for agitated-hoover-61371e ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Preview on netlify: https://deploy-preview-217--pull-request.netlify.app/ |
MichalPorag
reviewed
Jun 28, 2022
Collaborator
MichalPorag
left a comment
MichalPorag
left a comment
There was a problem hiding this comment.
Great work! thank you!
InbarDanieli
commented
Jun 29, 2022
MichalPorag
requested changes
Jul 2, 2022
Collaborator
MichalPorag
left a comment
MichalPorag
left a comment
There was a problem hiding this comment.
Please stay focus on the specific task
| * @param FullInfo | ||
| * @returns | ||
| */ | ||
| function ProjectsPage({ stars, license, languages, projectname }: githubFullinfo) { |
Collaborator
There was a problem hiding this comment.
Please move type to new Interface
| <Link shallow href="/"> | ||
| <a className={className}> | ||
| <Img className="inner-logo" src="/images/logo-2.0.svg" /> | ||
| <Img layout="fill" className="inner-logo" src="/images/logo-2.0.svg" /> |
Collaborator
There was a problem hiding this comment.
What layout="fill" is for?
Contributor
Author
There was a problem hiding this comment.
without it i get this error
Also happens in master
MichalPorag
approved these changes
Jul 12, 2022
Collaborator
MichalPorag
left a comment
MichalPorag
left a comment
There was a problem hiding this comment.
never mind. let's talk about that after you return.
for now, it looks good so I'm merging :)
Collaborator
|
@InbarDanieli please fix conflicts so we can merge :) |
…-community into feat/fetch-github-repo
Contributor
Author
|
@MichalPorag conflicts have been fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What New?
ownerandrepopages to create a generic page that gets projects information depending on the URL's pathexample
When entering this URL:
https://pullrequest.co.il/projects/Pull-Request-Community/pull-request-community-websiteyou will see some of the information on the pull request community website repo
close #137