Fix context menus rendering behind floating sidebar toolbar#580
Open
Fix context menus rendering behind floating sidebar toolbar#580
Conversation
Collapse stacking contexts on sidebar toolbar elements when a session or group context menu is open, so the position:fixed menu (z-index:10000) can paint above everything. Also bump sidebar-header z-index when the header overflow menu is active. Three changes: - Remove unnecessary z-index:2 from .session-actions - Add has-open-menu class to sidebar-content, collapse stacking contexts on toolbar/filter/compose/support elements via z-index:auto - Bump .sidebar-header z-index to 50 when header overflow is hovered/focused Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Context menus (session right-click, group
⋯menu, header⋯overflow) render behind the floating sidebar toolbar buttons (New, Manual sort, refresh, filter chips).Root Cause
Multiple positioned elements with explicit
z-indexvalues create stacking contexts that trap descendantposition: fixedmenus — even though the menus havez-index: 10000, they can't escape a parent stacking context with a lower z-index.Fix
has-open-menuCSS class tosidebar-contentwhen any menu is open. Collapse stacking contexts on toolbar elements (sidebar-top-tools,sidebar-compose-panel,sidebar-organize-shell-compact,sidebar-support-fab) toz-index: auto— buttons stay visible but the menu paints on top.:has()to bump.sidebar-headerfrom z-index 3 → 50 when the overflow is hovered/focused.z-index: 2from.session-actions.