Skip to content

Omit empty target attribute when not provided #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oyessb merged 1 commit into from
Apr 7, 2026
Merged

Omit empty target attribute when not provided #1196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/pxweb2-ui/src/lib/components/Link/Link.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React from 'react';
import { render, screen } from '@testing-library/react';
import '@testing-library/jest-dom/vitest';

import Link from './Link';

Expand All @@ -13,11 +14,11 @@ describe('Link', () => {
expect(link.getAttribute('href')).toBe('#');
});

it('sets empty target attribute when target prop is not provided', () => {
it('omits target attribute when target prop is not provided', () => {
render(<Link href="#">{linkText}</Link>);
const link = screen.getByRole('link');
// target="" is explicitly set in component when no target passed
expect(link.getAttribute('target')).toBe('');
expect(link).not.toHaveAttribute('target');
expect(link.getAttribute('target')).toBeNull();
});

it('applies target attribute when provided', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/pxweb2-ui/src/lib/components/Link/Link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const Link = forwardRef<HTMLAnchorElement, LinkProps>(function Link(
return (
<a
href={href}
target={target ? target : ''}
target={target}
className={cl(classes.link, {
[classes.no_underline]: noUnderline,
[classes.inline]: inline,
Expand Down
Loading