use PyIter_NextItem during iteration
#5661
Draft
+34
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Seems like there is a minor performance loss in (e.g.) set iteration. Looks like the set iterator has a |
Member
Author
|
For generic iterators, this does seem to be slightly faster: 
|
davidhewitt
commented
Nov 30, 2025
| /// If an exception occurs, returns `Some(Err(..))`. | ||
| /// Further `next()` calls after an exception occurs are likely | ||
| /// to repeatedly result in the same exception. | ||
| #[inline] |
Member
Author
There was a problem hiding this comment.
Probably don't need this inlining hint any more?
Suggested change
| #[inline] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly more interesting after #5660 which will show if there is any benchmark improvement here :)