Fix estimation for sequestration potentials#2086
Conversation
… and make sure optimistic assumptions are >= neutral assumptions
for more information, see https://pre-commit.ci
|
@lisazeyen, if you have a moment, could you say whether that's correct? I think you once mentioned something specific about the accounting of the sequestration potentials. |
|
I think we only considered high-density storage so far. But I am not sure if there is some double counting. I am currently on holidays until the 8/3 does this have some time? Then I could look at my notes at home. In my PhD thesis I wrote different numbers (total sequestration 18 Gt: 9 Gt gas, 5Gt oil, 4 Gt aquifer) and I am not sure where the mismatch is coming from, is it including onshore? |
|
@lisazeyen, I'm unsure how to judge this. Maybe you have the chance to have a look at your notes in the upcoming days? |
|
|
||
| gdf = merge_maps(traps_map, storage_map) | ||
|
|
||
| types = [" OIL", " GAS", " aquifer", ""] |
There was a problem hiding this comment.
It should be either just the high-density storage or the conservative storage potential
| types = [" OIL", " GAS", " aquifer", ""] | |
| types = [" OIL", " GAS", " aquifer"] |
|
@fneum @toniseibold sorry for the late reply. One should include just one of the two: either the conservative estimation or only consider the high-density storage (gas, oil, aquifer). We actually already discussed this in this PR. I would recommend to use only high-density storage because this is where most projects are planned. @toniseibold I still wonder why the numbers are slightly different in my PhD thesis compared to what is in the PR description, but might be just that I rounded the numbers. |
fneum
left a comment
There was a problem hiding this comment.
Sounds good. Thanks @lisazeyen for checking (again)!
@toniseibold, I would avoid the .max(axis=1) hotfix if possible. See comment below.
| for t in types: | ||
| opt_col = f"optimistic estimate{t} Mt" | ||
| neu_col = f"neutral estimate{t} Mt" | ||
|
|
||
| gdf[opt_col] = gdf[[opt_col, neu_col]].max(axis=1) |
There was a problem hiding this comment.
Is this still necessary one @lisazeyen 's suggested changes are implemented? I would avoid that "correction" and work with the actual values in the dataset if possible.
|
|
||
| gdf = merge_maps(traps_map, storage_map) | ||
|
|
||
| types = [" OIL", " GAS", " aquifer", ""] |

Ensuring that the optimistic sequestration potential is equal or greater than the neutral estimation. In raw data e.g.
data/CO2JRC_OpenFormats/CO2Stop_DataInterrogationSystem/Hydrocarbon_Traps.csvoptimistic assumption is zero in some cases while neutral estimations are > 0.Removing "conservative estimate Mt" from config since this leads to double counting of the sequestration potential in rule
build_clustered_co2_sequestration_potentials.Checklist
pixi.toml(usingpixi add <dependency-name>). not_applicableconfig/config.default.yaml.doc/configtables/*.csv. not applicabledoc/release_notes.rstis added. not applicable