Allow allow subregional NUTS selection.#2146
Open
bobbyxng wants to merge 6 commits into
Open
Conversation
fneum
requested changes
May 4, 2026
Member
fneum
left a comment
fneum
left a comment
There was a problem hiding this comment.
Looks great in general. Two questions.
Could you test for a few administrative clustering cases (also not using the new feature), just to be sure it doesn't break anything? Cheers!
| subregion_level = { | ||
| k: v | ||
| for k, v in countries_config.items() | ||
| if len(k) > 2 and k[:2] in countries |
Member
There was a problem hiding this comment.
Does that also work for the UK, where it shows up as GB in country list but NUTS codes are UK...?
| # Only keep the values whose keys are in countries | ||
| countries_config = admin_levels.get("countries", {}) | ||
| country_level = { | ||
| k: v for k, v in admin_levels.items() if (k != "level") and (k in countries) |
Member
There was a problem hiding this comment.
Shouldn't it still be necessary to filter out the "level" here? Why can it be removed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Checklist
Required:
doc/release_notes.rst.If applicable:
scripts/lib/validation.doc/*.rstfiles.