Feat: SBOM vulnerability scan#2164
Open
brynpickering wants to merge 5 commits into
Open
Conversation
- Uploads pixi default deps to github dependency list - Uploads identified vulnerabilities to codeQL vulnerabilities list - Identifies vulnerabilities on updates to pixi.lock - Move unnecessary deps from `default` to `dev` env (jupyter introduces `npm` `ip` package vulnerability `cve-2024-29415`). Assisted-by: Claude:Sonnet 4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defaulttodevenv (jupyter introducesnpmippackage vulnerability cvs-2024-29415).As is ever the case with these kinds of PRs, I find it impossible to successfully test the workflows locally, even with
act(docker and osx-arm64 aren't the best of friends). So, I don't know for sure that they work as expected...What you get:
master, the repo dependencies are uploaded to the github API so they are correctly represented in the dependency graph.master, the latest identified vulnerabilities are uploaded to the repo CodeQL vulnerability list.pixi.lockin a PR tomaster, a comment is added with a table of vulnerabilities identified in the updated env.Note
PR comment doesn't work correctly in PRs from forks, as noted by the action maintainer. We could update this to be triggered on
pull_request_targetbut there are other concerns then about vulnerabilities introduced by bad actors via the action.This is all needed because native github tools (CodeQL & dependabot) don't analyse
pixi.lockfiles.Required:
doc/release_notes.rst.If applicable:
scripts/lib/validation.doc/*.rstfiles.