Fix build issues, crashes, and Rules Editor remove button#100
Open
jrhubott wants to merge 9 commits intoPyroh:mainfrom
Open
Fix build issues, crashes, and Rules Editor remove button#100jrhubott wants to merge 9 commits intoPyroh:mainfrom
jrhubott wants to merge 9 commits intoPyroh:mainfrom
Conversation
…te Sparkle to SPM Remove empty shell script pre/post actions from Fluor.xcscheme that caused build failures. Update MACOSX_DEPLOYMENT_TARGET from 10.12 to 10.13 to match SmoothOperators minimum requirement. Replace manual Sparkle.framework reference (hardcoded to original developer's path) with Swift Package Manager dependency on Sparkle 2.x, and update storyboard references from SUUpdater to SPUStandardUpdaterController.
…indows The Rules Editor crash was caused by a toolTip binding using the nested key path `objectValue.url.path`. The `url` property on Item is declared as `@objc let`, which doesn't expose a mutable ivar to the ObjC runtime. When KVO set up auto-notifying for this nested path, NSKeyValueIvarSetter received a nil ivar and dereferenced it (address 0x0). Also removed the unused selectionIndexes binding on the table view, changed both windows from NSPanel to NSWindow (customClass removal), and updated editRules/showRunningApps to use makeKeyAndOrderFront with NSApp.activate — matching the working pattern from showAbout/showPreferences.
Migrate Preferences.storyboard Sparkle bindings to use the v2 key paths (self.updater.automaticallyChecksForUpdates, etc.) and remove the unused SPUStandardUpdaterController custom object. Bump CFBundleVersion to 2371 and downgrade scheme version to 1.3 for broader Xcode compatibility.
…ntroller The "-" button in the Rules Editor was permanently disabled because the table view's selectionIndexes were not bound to the NSArrayController. Without this binding, canRemove stayed false and selectedObjects was always empty. Also updates CLAUDE.md with gotchas and bumps build number.
# Conflicts: # Fluor.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@objc letproperties)Test plan
xcodebuild -scheme Fluor -configuration Debug build