Skip to content

chore: Attempt to reduce a01 test flakiness by fixing shutdown to reduce number of active threads #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenporter merged 3 commits into from
Aug 4, 2025
Merged

chore: Attempt to reduce a01 test flakiness by fixing shutdown to reduce number of active threads #420

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f748b18
chore: Add timeout to queue request to diagnose
allenporter Aug 3, 2025
01a7d5f
chore: fix a01 client
allenporter Aug 3, 2025
d098817
chore: fix lint errors
allenporter Aug 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tests/test_a01_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
from . import mqtt_packet
from .conftest import QUEUE_TIMEOUT

RELEASE_TIMEOUT = 2


@pytest.fixture(name="a01_mqtt_client")
async def a01_mqtt_client_fixture(
Expand All @@ -59,9 +61,11 @@ async def a01_mqtt_client_fixture(
try:
yield client
finally:
if not client.is_connected():
# Cleanup is best effort to reduce number of active threads
if client.is_connected():
try:
await client.async_release()
async with asyncio.timeout(RELEASE_TIMEOUT):
await client.async_release()
except Exception:
pass

Expand Down Expand Up @@ -207,8 +211,8 @@ async def test_set_value(
"""Test sending an arbitrary MQTT message and parsing the response."""
# Clear existing messages received during setup
assert received_requests.qsize() == 2
assert received_requests.get(block=True)
assert received_requests.get(block=True)
assert received_requests.get(block=True, timeout=QUEUE_TIMEOUT)
assert received_requests.get(block=True, timeout=QUEUE_TIMEOUT)
assert received_requests.empty()

# Prepare the response message
Expand Down
Loading