chore: update container parsing using native typing and dataclass #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lash-L
reviewed
Aug 9, 2025
Lash-L
approved these changes
Aug 9, 2025
Collaborator
Lash-L
left a comment
Lash-L
left a comment
There was a problem hiding this comment.
this looks good. Seemingly we can also in the future take advantage of this and decrease the size of the containers file now that i think they all shouldn't have to be together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamline the container parsing using modern python constructs for iterating over types. This adds support for nested dictionaries, and consolidates a few versions of similar logic into fewer places.