feat: add dynamic clean modes #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenporter
reviewed
Aug 10, 2025
Contributor
allenporter
left a comment
allenporter
left a comment
There was a problem hiding this comment.
Structure looks good to me. I might suggest adding some higher level comments simiiar to what were discussing about why these various behaviors exist for different mode (e.g. if there is some physical feature involved, explaining that)
Collaborator
Author
Good call out - can do |
allenporter
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow us to dynamically set the valid modes.
Needs to be integrated but wanted some feedback on structure