fix: switches commands were incorrect #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the command structures for timer settings in Roborock devices, specifically addressing how the enable() and disable() methods interact with the device API. The changes correct the parameter format and use appropriate commands for disabling timers.
- Changed
enable()methods to send parameters as a list of timer values instead of a dictionary - Updated
disable()methods to use dedicatedCLOSE_*_TIMERcommands instead of attempting to disable viaSET_*_TIMER
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| roborock/devices/traits/v1/valley_electricity_timer.py | Updated enable() to send timer values as a list; changed disable() to use CLOSE_VALLEY_ELECTRICITY_TIMER command |
| roborock/devices/traits/v1/do_not_disturb.py | Updated enable() to send timer values as a list; changed disable() to use CLOSE_DND_TIMER command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Lash-L
commented
Nov 14, 2025
| export default { | ||
| extends: ["@commitlint/config-conventional"], | ||
| ignores: [(msg) => /Signed-off-by: dependabot\[bot]/m.test(msg)], | ||
| ignores: [ |
Collaborator
Author
There was a problem hiding this comment.
unrelated change, but i think worthwhile
allenporter
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structure for the timers was incorrect, this is now working in my tests