-
Notifications
You must be signed in to change notification settings - Fork 57
feat: Add mappings for cleaning fluid states. #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add mappings for cleaning fluid states. #636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for tracking the cleaning fluid container status in the Roborock integration by introducing a new CleanFluidStatus enum and updating the clean_fluid_status property to use it.
- Introduces
CleanFluidStatusenum with values for empty/not installed and okay states - Updates the
clean_fluid_statusproperty to return the enum type and handle unsupported devices - Implements feature detection by returning
Nonewhen the device doesn't support the cleaning fluid feature
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| roborock/data/v1/v1_code_mappings.py | Adds CleanFluidStatus enum with empty_not_installed and okay states |
| roborock/data/v1/v1_containers.py | Updates clean_fluid_status property to use the new enum type and adds feature detection logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0c02b26 to
a195c42
Compare
|
Added "feat: " prefix to commit message to fix failing workflow step. |
|
Thank you! I'll double check the logic and will merge this. We're in a bit of sprint right now working on reliability. But as soon as we get over that, i'll be merging in some non-reliability based things like this. |
a195c42 to
ad5b7f4
Compare
|
No worries! I'm aware of the ongoing issue right now and appreciate the support you guys are putting into the fix 😄 |
|
Hi @pauloruberto can you do me a favor and check the response of the Status object? This code would work: And modify RoborockBase.from_dict() to contain this: right after And let me know if 'switch_status' exists as a key? Alternatively you can use a debugger if you would rather. |
|
Hey @Lash-L! I made a small script and executed it with the above, and I'm not seeing any |
|
hmm odd. Thanks for checking @pauloruberto! |
Lash-L
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked reversed engineered code - seems accurate.
This PR adds support for tracking the cleaning fluid container status in the Roborock integration. The main changes introduce a new enum for cleaning fluid status, update the container logic to use this enum, and ensure the feature is only reported if supported by the device.
This was tested using the Saros Z70, which has a cleaning fluid dispenser. Also a Qrevo Curv and QX Revo Ultra which do not have cleaning fluid dispensers.