Skip to content

fix: Consider RPC channel health based on MQTT session #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenporter merged 1 commit into from
Dec 7, 2025
Merged

fix: Consider RPC channel health based on MQTT session #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roborock/devices/v1_channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ def is_local_connected(self) -> bool:
@property
def is_mqtt_connected(self) -> bool:
"""Return whether MQTT connection is available."""
return self._mqtt_unsub is not None and self._mqtt_channel.is_connected
return self._mqtt_channel.is_connected

@property
def rpc_channel(self) -> V1RpcChannel:
Expand Down
2 changes: 1 addition & 1 deletion tests/devices/test_v1_channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ async def test_v1_channel_subscribe_local_success(
assert mock_local_channel.subscribers

# Verify properties
assert not v1_channel.is_mqtt_connected
assert v1_channel.is_mqtt_connected
assert v1_channel.is_local_connected

# Test unsubscribe cleans up both
Expand Down