Skip to content

feat: expose prefer-cache to create_device_manager caller #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenporter merged 1 commit into from
Dec 29, 2025
Merged

feat: expose prefer-cache to create_device_manager caller #719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion roborock/devices/device_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ async def create_device_manager(
session: aiohttp.ClientSession | None = None,
ready_callback: DeviceReadyCallback | None = None,
mqtt_session_unauthorized_hook: SessionUnauthorizedHook | None = None,
prefer_cache: bool = True,
) -> DeviceManager:
"""Convenience function to create and initialize a DeviceManager.

Expand All @@ -198,6 +199,7 @@ async def create_device_manager(
mqtt_session_unauthorized_hook: Optional hook for MQTT session unauthorized
events which may indicate rate limiting or revoked credentials. The
caller may use this to refresh authentication tokens as needed.
prefer_cache: Whether to prefer cached device data over always fetching it from the API.

Returns:
An initialized DeviceManager with discovered devices.
Expand Down Expand Up @@ -259,5 +261,5 @@ def device_creator(home_data: HomeData, device: HomeDataDevice, product: HomeDat
return dev

manager = DeviceManager(web_api, device_creator, mqtt_session=mqtt_session, cache=cache, diagnostics=diagnostics)
await manager.discover_devices()
await manager.discover_devices(prefer_cache)
return manager