Skip to content

Conversation

@allenporter
Copy link
Contributor

Add the home data API product info and device info for a Saros 10R, captured from diagnostics.

Some followup up considerations:

  • This is building a parallel world to device_info.yaml so we may want to converge these (e.g. allow either diagnostic or CLI based contributions in the same format)
  • The product naming is not very readable since its using the model name which may be hard to read, so we can consider renaming the files.

Add the home data API product info and device info for a Saros 10R, captured from diagnostics.

Some followup up considerations:
- This is building a parallel world to device_info.yaml so we may want to converge these (e.g. allow either diagnostic or CLI based contributions in the same format)
- The product naming is not very readable since its using the model name which may be hard to read, so we can consider renaming the files.
Copy link
Collaborator

@Lash-L Lash-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants