[SHELL] Fix the bug that spark-shell of XSQL cann't start#28
Open
WeiWenda wants to merge 1 commit intoQihoo360:masterfrom
Open
[SHELL] Fix the bug that spark-shell of XSQL cann't start#28WeiWenda wants to merge 1 commit intoQihoo360:masterfrom
WeiWenda wants to merge 1 commit intoQihoo360:masterfrom
Conversation
Collaborator
|
Could you add |
beliefer
added
improve
Collaborator
|
I think we should recurrent this issue and then supplement the description of issue. |
beliefer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As jline has be pre-configured in spark-parent by dependencyManagement, we should not set a different version of jline in spark-shell again. What's more, jline has been packaged by spark-assembly, there is no need to shade it into spark-shell jar in XSQL
pluginversion.