Open
Conversation
beliefer
reviewed
Oct 20, 2019
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.spark.sql.xsql.manager |
beliefer
reviewed
Oct 20, 2019
| def this() = { | ||
| this(null) | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
def this() = this(null)
beliefer
reviewed
Oct 20, 2019
| case HBASE => CatalogTableType.HBASE | ||
| case MYSQL | ORACLE => CatalogTableType.JDBC | ||
| case MYSQL | JDBC => CatalogTableType.JDBC | ||
| case DRUID => CatalogTableType.JDBC |
Collaborator
There was a problem hiding this comment.
case JDBC => CatalogTableType.JDBC ?
Collaborator
Author
There was a problem hiding this comment.
I haven't moved mysql to the jdbc module in this PR. So l didn't remove MYSQL for MysqlManager could work normally.
beliefer
reviewed
Oct 20, 2019
| type DataSourceType = Value | ||
| val HIVE, ELASTICSEARCH, MONGO, REDIS, MYSQL, KAFKA, HBASE, DRUID, ORACLE, EXTERNAL = Value | ||
| val HIVE, ELASTICSEARCH, MONGO, REDIS, JDBC, MYSQL, KAFKA, HBASE, DRUID, EXTERNAL = Value | ||
|
|
Collaborator
|
Could you make the description have more detail？ |
beliefer
reviewed
Oct 20, 2019
| <artifactId>xsql-hive_${scala.binary.version}</artifactId> | ||
| <version>${project.version}</version> | ||
| <scope>provided</scope> | ||
| </dependency> |
Collaborator
There was a problem hiding this comment.
Why there need the dependence xsql-hive ?
beliefer
reviewed
Oct 20, 2019
| <artifactId>*</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> |
Collaborator
Author
There was a problem hiding this comment.
These dependencies are used for testing.l forgot to remove them.
beliefer
reviewed
Oct 20, 2019
| } | ||
|
|
||
| class MysqlDataSource( | ||
| private val name: String, |
Collaborator
There was a problem hiding this comment.
Could we remove MysqlDataSource ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR imports JDBC module for XSQL, Creating class of
JDBCManagerand implementing some standard SQL functions. It works with some common jdbc data sources.How was this patch tested?
No UT.