refactor: ebit0 and ebit1 into a single shared ebit between Alice and Bob#4878
Open
grahamwhiteuk wants to merge 1 commit intoQiskit:mainfrom
Open
refactor: ebit0 and ebit1 into a single shared ebit between Alice and Bob#4878grahamwhiteuk wants to merge 1 commit intoQiskit:mainfrom
grahamwhiteuk wants to merge 1 commit intoQiskit:mainfrom
Conversation
… Bob Signed-off-by: Graham White <gwhite@uk.ibm.com>
Contributor
|
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 One or more of the following people are relevant to this code: |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
abbycross
added
needs triage 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was confused when reading this example. Since Alice and Bob share an ebit, using a naming convention of ebit0 and ebit1 doesn't make sense as this articulates that they are two separate ebits (which isn't the case). I have refactored in a way that makes it clear that there is a single ebit shared between Alice and Bob with their access to the ebit defined by a subscriptable variable.