Skip to content

Update PQK tutorial to conform to new template#4948

Open
MeltemTolunay wants to merge 7 commits into
mainfrom
mt/update-pqk-tutorial
Open

Update PQK tutorial to conform to new template#4948
MeltemTolunay wants to merge 7 commits into
mainfrom
mt/update-pqk-tutorial

Conversation

@MeltemTolunay
Copy link
Copy Markdown
Collaborator

No description provided.

@qiskit-bot
Copy link
Copy Markdown
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

One or more of the following people are relevant to this code:

  • @MeltemTolunay
  • @nathanearnestnoble

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nathanearnestnoble
Copy link
Copy Markdown
Collaborator

Comment 1:
we do not seems to follow template of a small scale simulator example followed by larger hardware demonstration. For this particular tutorial, I think the point of it is improved scalaibility compared to the original kernel method. In that regard, my suggested update would be:

  1. reference the quantum kernel tutorial and associated difficulty of scaling (large weight observable)
  2. Include 'small scale simulator example' section and either fill it out or state 'we skip this section as the purpose of this tutorial is to demonstrate how a quantum kernel can scale' (Id probably pick the second)

Comment 2:
I would personally suggest pulling the step 3/4 explanatory text into the background section, as it helps make it more clear why scaling works

Comment 3:
I think the sentence This tutorial also assumes general familiarity with QML methods. For further exploration of QML, refer to the [Quantum machine learning](https://github.com/Qiskit/documentation/blob/d82972aee109f8a42d897f345139020b8dd8daf8/docs/tutorials/learning/courses/quantum-machine-learning) course in IBM Quantum Learning. is a bit redundant, given prereq section.

@MeltemTolunay
Copy link
Copy Markdown
Collaborator Author

Thank you for the review, here is the summary of updates:

  1. Quantum kernel tutorial is linked, and I added a paragraph about scaling.
  2. I added a paragraph to background section explaining 1-RDMs. I still kept the equation in Section 3, because I think it's better for the flow and right above the section where we actually compute the RDMs.
  3. Removed the duplicate section.

Please let me know if any other changes are needed.

"\n",
"## Background\n",
"\n",
"*Usage estimate: 80 minutes on a Heron r3 processor (NOTE: This is an estimate only. Your runtime might vary.)*\n",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a duplicate, I remove it on my latest commit.

Comment thread docs/tutorials/projected-quantum-kernels.ipynb Outdated
Comment thread docs/tutorials/projected-quantum-kernels.ipynb Outdated
Comment thread docs/tutorials/projected-quantum-kernels.ipynb Outdated
Comment thread docs/tutorials/projected-quantum-kernels.ipynb Outdated
- Remove duplicate usage estimate from Background section
- Promote Requirements and Setup to h2 headings
- Move "If you found this work interesting" lead-in outside the Next steps admonition
Copy link
Copy Markdown
Collaborator

@henryzou50 henryzou50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the changes @MeltemTolunay! I added a review minor changes to make the tutorial more consistent with the template and the other tutorials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

5 participants