Skip to content

Enable codecov CI failure trigger again#69

Merged
weinbe58 merged 3 commits into
mainfrom
david/fix-codecov
May 19, 2026
Merged

Enable codecov CI failure trigger again#69
weinbe58 merged 3 commits into
mainfrom
david/fix-codecov

Conversation

@david-pl
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
1526 1416 93% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: eafd1d3 by action🐍

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-05-19 14:45 UTC

@weinbe58 weinbe58 marked this pull request as ready for review May 19, 2026 14:43
Copilot AI review requested due to automatic review settings May 19, 2026 14:43
@weinbe58 weinbe58 merged commit 11f6cc4 into main May 19, 2026
15 checks passed
@weinbe58 weinbe58 deleted the david/fix-codecov branch May 19, 2026 14:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Re-enables failing the CI workflow when the Codecov upload step errors, so coverage reporting problems surface as failed checks. It also updates the project’s development version.

Changes:

  • Set Codecov upload step to fail the workflow on upload errors (fail_ci_if_error: true).
  • Bump package version in pyproject.toml from 0.6.0-dev to 0.7.0-dev.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Updates the project development version to 0.7.0-dev.
.github/workflows/ci.yml Makes CI fail if the Codecov upload step encounters an error.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
[project]
name = "bloqade-core"
version = "0.6.0-dev"
version = "0.7.0-dev"
Comment thread .github/workflows/ci.yml
with:
files: coverage.xml # optional
fail_ci_if_error: false # optional (default = false) -- TODO change back to true once we fix codecov after rename
fail_ci_if_error: true # optional (default = false) -- TODO change back to true once we fix codecov after rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants