Draft
Conversation
…l; still slower than sequential
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 98.87% 97.91% -0.97%
==========================================
Files 10 10
Lines 2227 2253 +26
==========================================
+ Hits 2202 2206 +4
- Misses 25 47 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
Collaborator
Author
|
No change on machines with dual-channel memory (presumably 2 threads already saturate memory bandwidth) but on an 8-channel server this gives a 30% improvement end-to-end, although the safe version only achieves a 10% improvement. We need to bring down the overhead of tracking disjoint regions, and add heuristics for selecting the parallel impl over the default one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same approach as #97 but applies to CO-BRAVO tiles instead of the inner BRAVO
While the first two commits are 100% safe, the third introduced unsafe just to see what the performance ceiling is without any overhead. Still slower than sequential on 2 threads on my machine with dual-channel memory; needs measurement on servers with more memory channels.