[CQT-417] Circuit builder accepts multiple registers #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Guy Puts <guy.puts@tno.nl> Co-authored-by: Guy Puts <38719377+GuyPuts@users.noreply.github.com> Co-authored-by: Juan Boschero <juan.boschero@tno.nl> Co-authored-by: rturrado <rturrado@gmail.com> Co-authored-by: Juan Carlos Boschero <juanboschero1998@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: rares1609 <79575613+rares1609@users.noreply.github.com> Co-authored-by: Oancea <rares.oancea@tno.nl>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: rturrado <rturrado@gmail.com> Co-authored-by: Juan Boschero <juan.boschero@tno.nl> Co-authored-by: Guy Puts <guy.puts@tno.nl> Co-authored-by: Guy Puts <38719377+GuyPuts@users.noreply.github.com> Co-authored-by: Juan Carlos Boschero <juanboschero1998@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: rares1609 <79575613+rares1609@users.noreply.github.com> Co-authored-by: Oancea <rares.oancea@tno.nl>
rares1609
requested changes
Jan 19, 2026
Contributor
rares1609
left a comment
rares1609
left a comment
There was a problem hiding this comment.
The issue looks good to me. The CircuitBuilder now accepts multiple (qu)bit registers which can be inserted in-between instructions. I think there are two (minor) points that still need to be addressed before its merged:
- The comment concerning the assert statement, I am not certain whether it is redundant or done on purpose.
- An entry needs to be added to the Changelog.
Contributor
davidbakker123
left a comment
davidbakker123
left a comment
There was a problem hiding this comment.
I was half way through the review, but rares finished. So I will leave it here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.