Skip to content

fix: guard GitHub App token setup #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Apr 2, 2026
Merged

fix: guard GitHub App token setup #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/monthly_optimization_planner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,21 @@ jobs:
- name: Checkout
uses: actions/checkout@v6

- name: Detect GitHub App credentials
id: cross_repo_credentials
env:
APP_ID: ${{ vars.CROSS_REPO_GITHUB_APP_ID }}
APP_PRIVATE_KEY: ${{ secrets.CROSS_REPO_GITHUB_APP_PRIVATE_KEY }}
run: |
if [ -n "$APP_ID" ] && [ -n "$APP_PRIVATE_KEY" ]; then
echo "has_app_credentials=true" >> "$GITHUB_OUTPUT"
else
echo "has_app_credentials=false" >> "$GITHUB_OUTPUT"
fi

- name: Create GitHub App token for cross-repo access
id: cross_repo_app_token
if: vars.CROSS_REPO_GITHUB_APP_ID != '' && secrets.CROSS_REPO_GITHUB_APP_PRIVATE_KEY != ''
if: steps.cross_repo_credentials.outputs.has_app_credentials == 'true'
uses: actions/create-github-app-token@v2
with:
app-id: ${{ vars.CROSS_REPO_GITHUB_APP_ID }}
Expand Down
2 changes: 2 additions & 0 deletions tests/test_monthly_optimization_planner_workflow_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ def test_planner_workflow_downloads_artifacts_posts_issue_and_fans_out_tasks(sel
self.assertIn("CROSS_REPO_GITHUB_TOKEN", workflow)
self.assertIn("CROSS_REPO_GITHUB_APP_PRIVATE_KEY", workflow)
self.assertIn("CROSS_REPO_GITHUB_APP_ID", workflow)
self.assertIn("Detect GitHub App credentials", workflow)
self.assertIn("has_app_credentials", workflow)
self.assertIn("actions/create-github-app-token@v2", workflow)
self.assertIn("Resolve cross-repo access token", workflow)
self.assertIn("source=github_app", workflow)
Expand Down