Skip to content

ci: require env-scoped longport app secrets#4

Merged
Pigbibi merged 1 commit intomainfrom
codex/harden-env-sync-secret-scope
Mar 31, 2026
Merged

ci: require env-scoped longport app secrets#4
Pigbibi merged 1 commit intomainfrom
codex/harden-env-sync-secret-scope

Conversation

@Pigbibi
Copy link
Copy Markdown
Collaborator

@Pigbibi Pigbibi commented Mar 31, 2026

Summary

  • require LONGPORT_APP_KEY_SECRET_NAME and LONGPORT_APP_SECRET_SECRET_NAME for each GitHub Environment in sync-cloud-run-env
  • remove GitHub secret fallback for LongPort app key/app secret so HK/SG do not silently inherit shared repo defaults
  • update README and workflow test to match the env-scoped Secret Manager setup

Verification

  • bash tests/test_sync_cloud_run_env_workflow.sh
  • python -m unittest discover -s tests -v
  • ruff check .

Operational follow-up

  • removed repo-level variables LONGPORT_APP_KEY_SECRET_NAME and LONGPORT_APP_SECRET_SECRET_NAME
  • confirmed longbridge-hk and longbridge-sg each have their own env-scoped secret-name vars
  • granted roles/secretmanager.secretAccessor on longport-app-key-hk and longport-app-secret-hk to longbridge-platform-runtime@longbridgequant.iam.gserviceaccount.com

@Pigbibi Pigbibi merged commit 21687b3 into main Mar 31, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/harden-env-sync-secret-scope branch March 31, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant