Settings to filter out posts with few comments#1298
Open
mosteo wants to merge 4 commits intoQuantumBadger:masterfrom
Open
Settings to filter out posts with few comments#1298mosteo wants to merge 4 commits intoQuantumBadger:masterfrom
mosteo wants to merge 4 commits intoQuantumBadger:masterfrom
Conversation
When the checkbox is enabled, the user is asked for the minimum number of comments. This info is shown as the summary of the checkbox, when it is enabled. A toast is shown when comments are filtered, just as a reminder that this filter is in effect.
Author
|
Passing checks now. Sorry for the noise, I failed to open the PR in draft mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another attempt at #1176, with the feedback that was given there.
When the checkbox is enabled, the user is asked for the minimum number of comments. This info is shown as the summary of the checkbox, when it is enabled. This way there are no visible magic numbers or values with special significance.
A toast is shown when comments are filtered, just as a reminder that this filter is in effect.
Caveat: while I did #1176 entirely the old fashioned way, I used Claude for this one. It's been some years since I developed for Android so I'm unable to catch whether something isn't idiomatic nowadays. I did test and review everything though, without noticing anything suspicious.