Add preference to disable video autoplay#1328
Open
cliambrown wants to merge 2 commits intoQuantumBadger:masterfrom
Open
Add preference to disable video autoplay#1328cliambrown wants to merge 2 commits intoQuantumBadger:masterfrom
cliambrown wants to merge 2 commits intoQuantumBadger:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant feature request: #1075
Untested: Waiting on Reddit to give me an API key (they seem to have made this process more complicated)
Similar to my previous PR #1323
pref_behaviour_video_autoplay(default = true to match current behaviour) with a corresponding checkbox on the "Images/Video" settings pagepref_behaviour_video_autoplayis false and playback controls are enabled (because I assume that there would be no way to initiate playback otherwise)pref_behaviour_video_playback_controlsis false (btw, this could be applied to other relevant preference checkboxes using theandroid:dependencyattribute)strings.xmlexplaining this limitationExoPlayerWrapperViewconstructor by callingmVideoPlayer.setPlayWhenReady(false)instead of(true)— can't be sure that this is the correct approach without an API key