Merged
Conversation
lpiwowar
force-pushed
the
lpiwowar/config-default-api
branch
from
b9d025e to
9296298
Compare
lpiwowar
changed the title
/models
lpiwowar
force-pushed
the
lpiwowar/config-default-api
branch
from
9296298 to
9bbbd8e
Compare
EmilienM
reviewed
May 14, 2025
EmilienM
reviewed
May 14, 2025
EmilienM
approved these changes
May 14, 2025
Contributor
EmilienM
left a comment
EmilienM
left a comment
There was a problem hiding this comment.
This refactoring represents a significant step forward in terms of code maintainability. The introduction of the models package and the dynamic fetching of model capabilities are excellent changes. The codebase is now cleaner and more robust.
I dropped minor comments, mainly for sharing some thoughts, but really well done!
Feel free to merge when you think it's ready.
Let's discover all the config options that are available in the /models API call automatically. This commit removes all config options that do not need to be specified by the end user. The code related to models is moved to a separate package to ensure clear separation between the code related to models and the rest of the app.
EmilienM
force-pushed
the
lpiwowar/config-default-api
branch
from
9bbbd8e to
8202d3d
Compare
Contributor
|
@lpiwowar I rebased it for you, sorry for the merge conflict. It was only a package import in api.py. |
EmilienM
approved these changes
May 15, 2025
This was referenced May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's discover all the config options that are available in the /models API call automatically. This commit removes all config options that do not need to be specified by the end user.
The code related to models is moved to a separate package to ensure clear separation between the code related to models and the rest of the app.