解析機能におけるヘルスチェックをOAuthで連携する場合にのみ実施するように修正#177
Open
chiku-samugari wants to merge 1 commit intoRCOSDP:developfrom
Open
解析機能におけるヘルスチェックをOAuthで連携する場合にのみ実施するように修正#177chiku-samugari wants to merge 1 commit intoRCOSDP:developfrom
chiku-samugari wants to merge 1 commit intoRCOSDP:developfrom
Conversation
Gate eager BinderHub/JupyterHub health checks on `authorize_url` being present. When `authorize_url` is `null`, as in TLJH, no health check is performed, so the UI remains fully functional. This avoids the false failure caused by TLJH lacking /health and /hub/health endpoints.
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
解析機能においてTLJHを利用したときに「解析環境を起動する」ボタンが無効化され、解析環境を起動できないバグを修正する。
PR #159 で実装されたBinderHub/JupyterHubのヘルスチェックは、TLJHのように、OAuth2による連携を利用しないHubにおいては不要である。本PRではこのヘルスチェックをOAuth2による認証URL (
authorize_url) がnullでない場合にのみ行なうように修正することで、バグを修正する。Summary of Changes
BinderHub/JupyterHubのヘルスチェックを、OAuth2による認証URLが
nullでない場合にのみ行なうように修正QA Notes
chiku314/rdm-ember-osf-web:hotfix-gate-healthcheckをCustom Ember Imageとして指定して実行する