expired inbound payments stuck as Pending: test and fix#99
expired inbound payments stuck as Pending: test and fix#99bitwalt wants to merge 2 commits intoRGB-Tools:masterfrom
Conversation
nicbus
left a comment
nicbus
left a comment
There was a problem hiding this comment.
Please look for a test where this can be integrated, in order to avoid the cost of setting up a new one.
Also, please add the fix (as you proposed in #98 (comment)) on top of this commit.
bitwalt
force-pushed
the
inbound-expired-payments-test
branch
from
776d09c to
d00bea4
Compare
nicbus
left a comment
nicbus
left a comment
There was a problem hiding this comment.
a few more changes
please also update the openapi spec
src/ldk.rs
Outdated
| } | ||
| } | ||
|
|
||
| pub(crate) fn fail_inbound_pending_payments(&self) { |
There was a problem hiding this comment.
| pub(crate) fn fail_inbound_pending_payments(&self) { | |
| pub(crate) fn list_updated_payments(&self) { |
please return the list of updated payments so the calling methods don't need to get them a second time
There was a problem hiding this comment.
can i call it list_updated_inbound_payments instead of list_updated_payments ?
There was a problem hiding this comment.
yes, that was the intention, I mistyped
bitwalt
force-pushed
the
inbound-expired-payments-test
branch
from
d00bea4 to
97fa6d4
Compare
|
suggestions should have been addressed, changed the openapi in the other PR, do we need to change something also here? |
zoedberg
changed the title
nicbus
left a comment
nicbus
left a comment
There was a problem hiding this comment.
thanks, a few more details to address
please also rebase on top of the updated master
| // wait for the invoices to expire | ||
| tokio::time::sleep(std::time::Duration::from_secs(SHORT_EXPIRY_SEC as u64 + 1)).await; | ||
|
|
||
| let payment = get_payment(node2_addr, &decoded1.payment_hash).await; |
There was a problem hiding this comment.
| let payment = get_payment(node2_addr, &decoded1.payment_hash).await; | |
| // getting a payment should trigger expiration-based status transition | |
| let payment = get_payment(node2_addr, &decoded1.payment_hash).await; |
src/ldk.rs
Outdated
| self.get_inbound_payments().payments.clone() | ||
| } else { | ||
| inbound.payments.clone() | ||
| } |
There was a problem hiding this comment.
| self.get_inbound_payments().payments.clone() | |
| } else { | |
| inbound.payments.clone() | |
| } | |
| } | |
| inbound.payments.clone() |
src/ldk.rs
Outdated
| } | ||
| } | ||
|
|
||
| pub(crate) fn fail_inbound_pending_payments(&self) { |
There was a problem hiding this comment.
yes, that was the intention, I mistyped
yes, since this PR adds |
bitwalt
force-pushed
the
inbound-expired-payments-test
branch
from
97fa6d4 to
3aa646d
Compare
2 participants
this PR add a test to reproduce #98