Skip to content

chore(validation): Added first approach of SKILL_CHECKLIST file and validation script#20

Merged
dmartinol merged 6 commits intoRHEcosystemAppEng:mainfrom
r2dedios:ci/skill-validation-script
Mar 2, 2026
Merged

chore(validation): Added first approach of SKILL_CHECKLIST file and validation script#20
dmartinol merged 6 commits intoRHEcosystemAppEng:mainfrom
r2dedios:ci/skill-validation-script

Conversation

@r2dedios
Copy link
Copy Markdown
Contributor

@r2dedios r2dedios commented Feb 26, 2026

Summary

Introduces a SKILL validation script and a checklist with AgentSKills.io Specification requirements + our Claude Design patterns

Pack(s) affected

  • rh-sre
  • rh-developer
  • ocp-admin
  • rh-support-engineer
  • rh-virt
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (.mcp.json)
  • Docs / README
  • CI / tooling

CLAUDE.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)

…alidation script

Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
@r2dedios r2dedios self-assigned this Feb 26, 2026
@r2dedios r2dedios added the enhancement New feature or request label Feb 26, 2026
Copy link
Copy Markdown
Collaborator

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1- we need to find a single definition for the Skill specification document.
Let's compare SKILL_CHECKLIST.md from this PR and SKILL_DESIGN_PRINCIPLES.md from the main branch
2- I think python better fits the need to implement the compliance check, but we can add to it the missing checks that you added here.
WDYT?

Comment thread .github/workflows/README.md Outdated
Comment thread .github/workflows/validate-skills.yml Outdated
Comment thread .github/workflows/validate-skills.yml Outdated
Comment thread scripts/validate-skills.sh
Comment thread CLAUDE.md Outdated
Comment thread SKILL_CHECKLIST.md Outdated
…Linter

Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
@r2dedios
Copy link
Copy Markdown
Contributor Author

@dmartinol I modified the workflow for using ONLY the Skill Specification Linter script following the agentskills.io specs.

It also should detect the changes on the PR to do not evaluate every SKILL everytime. If you want to try it by your own, checkout this PR and run ./scripts/run-skill-linter.sh

Comment thread .github/workflows/skill-spec-report.yml
Comment thread SKILL_CHECKLIST.md Outdated
Copy link
Copy Markdown
Collaborator

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor comments. haven't tested locally yet, but I will
Thank you!

…ATTERNS.md files and updated skill validation scripts

Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
@r2dedios
Copy link
Copy Markdown
Contributor Author

r2dedios commented Mar 2, 2026

@dmartinol SKILL design files were merged and workflow scripts updated

@r2dedios r2dedios requested a review from dmartinol March 2, 2026 11:23
Copy link
Copy Markdown
Collaborator

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dmartinol dmartinol merged commit f394aef into RHEcosystemAppEng:main Mar 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants