Skip to content

Add Fleet Manager build integration#683

Open
sepast wants to merge 6 commits into
devfrom
feature_FleetManagerBuildIntegration
Open

Add Fleet Manager build integration#683
sepast wants to merge 6 commits into
devfrom
feature_FleetManagerBuildIntegration

Conversation

@sepast
Copy link
Copy Markdown
Contributor

@sepast sepast commented May 12, 2026

No description provided.

Comment thread atos/CMakeLists.txt
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a WITH_TRUCK_OBJECT_CONTROL CMake option and appended the module to ENABLED_MODULES when the flag is enabled.
This was needed so the new TruckObjectControl module can be built selectively without changing the default build path for existing environments.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced tf2::toMsg / tf2::fromMsg helper usage with direct quaternion field assignment/construction and added the missing tf2::Matrix3x3 include.
This was done to make the quaternion conversions compile reliably across ROS distros where the tf2_geometry_msgs helper API availability differs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added explicit tf2 linear math headers and replaced message-conversion helpers with direct quaternion component copies.
Updated Path header stamping so the path header and pose timestamps share the same time base.
These changes were needed to restore compilation under newer ROS environments and keep emitted path timestamps internally consistent.

Comment thread atos/common/util.c
Copy link
Copy Markdown
Contributor Author

@sepast sepast May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing return statements, corrected debug fprintf calls, fixed a bad string terminator assignment, and corrected mismatched debug format arguments.
These changes were needed to resolve hard compiler errors and non-void fallthrough warnings that blocked the build on stricter toolchains.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a direct #include <rclcpp/rclcpp.hpp>.
This was needed because the implementation now depends on rclcpp::Time / rclcpp::Duration being declared from the public header path, rather than relying on indirect includes.

Copy link
Copy Markdown
Contributor Author

@sepast sepast May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a null/failed-service guard before reading the object-control-state response.
This was needed to prevent the integration test process from crashing when the service call fails during startup or scenario-loading delays.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made SE_ReportObjectPos conditional on the ROS build environment: Humble keeps the timestamp argument, other environments use the shorter signature.
This was needed because the installed esmini headers differ between environments, so one fixed call signature could not compile everywhere.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increased the waits for trajectory, IP, and origin service responses, and extended the overall scenario-loading timeout.
This was needed because CI/container startup is slower than local runs, and the previous timeouts were causing false scenario-load failures during integration testing.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added libssl-dev.
This was needed to satisfy SSL/TLS-related build or runtime dependencies introduced by the current branch's environment and bridge usage.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled foxglove_bridge for the integration test launch and increased the test timeout from 30s to 60s.
This was needed because foxglove_bridge was failing in the test container while not being relevant to the scenario test itself, and the previous timeout was too short for slower CI runs.

@sepast sepast marked this pull request as ready for review May 13, 2026 11:49
@sepast sepast requested a review from samuelthoren May 13, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant