-
Notifications
You must be signed in to change notification settings - Fork 270
[CK] add inter/intrawave scheduling concept doc #3660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[CK] add inter/intrawave scheduling concept doc #3660
Conversation
AviralGoelAMD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT! Thank you!
lpaoletti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few subjective comments.
Can't make our products possessive.
| Intrawave and interwave scheduling with CK Tile | ||
| ************************************************************ | ||
|
|
||
| Two different scheduling pipelines are available to use with CK Tile's GEMM implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Two different scheduling pipelines are available to use with CK Tile's GEMM implementation. | |
| Two scheduling pipelines are available to use with the CK Tile GEMM implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like mine better
|
|
||
| Two different scheduling pipelines are available to use with CK Tile's GEMM implementation. | ||
|
|
||
| The interwave and intrawave scheduling pipelines coordinate waves in K dimension accumulation loops. Whether to use the interwave or intrawave pipeline depends on whether the workload is memory-bound or compute-bound. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no hyphen in "k dimension", right? right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
|
|
||
| The interwave and intrawave scheduling pipelines coordinate waves in K dimension accumulation loops. Whether to use the interwave or intrawave pipeline depends on whether the workload is memory-bound or compute-bound. | ||
|
|
||
| In interwave scheduling, the K dimension is separated into chunks. The same chunk is loaded into each wave. When the chunk has been loaded into all the waves, the same operation is run on the chunk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| In interwave scheduling, the K dimension is separated into chunks. The same chunk is loaded into each wave. When the chunk has been loaded into all the waves, the same operation is run on the chunk. | |
| In interwave scheduling, the K dimension is separated into chunks. The same chunk is loaded into each wave. Once the chunk has been loaded into all the waves, the same operation is run on the chunk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the sentences altogether.
Proposed changes
Adding information about inter/intrawave scheduling